Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing error when transforming outputs in middleware #684

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

jpwilliams
Copy link
Member

@jpwilliams jpwilliams commented Aug 21, 2024

Summary

Allows passing an error when using onFunctionRun.transformOutput in middleware.

Runtime code already supports this, allowing for common actions such as recreating (or creating new) errors based on data returned from executions. For example:

new InngestMiddleware({
  name: "My Middleware",
  init() {
    return {
      onFunctionRun({ fn }) {
        return {
          transformOutput({ result }) {
            if (result.error && result.error instanceof ForbiddenError) {
              return {
                result: {
                  error: new NonRetriableError(result.error.message),
                },
              };
            }
          },
        };
      },
    };
  },
});

Checklist

  • Added a docs PR that references this PR N/A Bug fix
  • Added unit/integration tests
  • Added changesets if applicable

@jpwilliams jpwilliams added the Bug Something isn't working label Aug 21, 2024
@jpwilliams jpwilliams self-assigned this Aug 21, 2024
Copy link

changeset-bot bot commented Aug 21, 2024

🦋 Changeset detected

Latest commit: 76196c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
inngest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jpwilliams jpwilliams requested a review from amh4r August 21, 2024 16:38
@inngest-release-bot inngest-release-bot added the 📦 inngest Affects the `inngest` package label Aug 21, 2024
@jpwilliams jpwilliams merged commit ae7ea5c into main Aug 21, 2024
46 checks passed
@jpwilliams jpwilliams deleted the fix/transformoutput-error-type branch August 21, 2024 16:56
jpwilliams pushed a commit that referenced this pull request Aug 21, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## inngest@3.22.5

### Patch Changes

- [#682](#682)
[`2019fe2`](2019fe2)
Thanks [@goodoldneon](https://github.com/goodoldneon)! - Fix empty
response body when streaming

- [#684](#684)
[`ae7ea5c`](ae7ea5c)
Thanks [@jpwilliams](https://github.com/jpwilliams)! - Allow passing
`error` when transforming outputs in middleware

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working 📦 inngest Affects the `inngest` package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants