fix(inngest): add JsonError export from types
#687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4cb3624 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I can confirm that this fixes the issue. We were also seeing this error after updating the Inngest SDK. However, our project does not use the |
|
As far as I know composite is just a stricter build. But anyway it doesn’t really matter whether the composite is the issue here. Glad that it fixes that for you.
…On Aug 23, 2024 at 15:54 +0200, Jan Vennemann ***@***.***>, wrote:
I can confirm that this fixes the issue. We were also seeing this error after updating the Inngest SDK. However, our project does not use the composite option.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
jpwilliams
added
Bug
jpwilliams
approved these changes
Aug 29, 2024
Merged
jpwilliams
pushed a commit
that referenced
this pull request
Sep 2, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## inngest@3.22.7 ### Patch Changes - [#687](#687) [`9f0bdc6`](9f0bdc6) Thanks [@MonsterDeveloper](https://github.com/MonsterDeveloper)! - Add exports for `JsonError` type to fix a TypeScript error when using Inngest in projects with `composite` setting in `tsconfig`. Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added an export for
JsonErrortype toindex.tsfromtypes.Checklist
Added a docs PR that references this PRN/A bug fixAdded unit/integration testsN/A only touches typesRelated
Fixes #686