Fix false indeterminate function warning #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0a680b4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jacobheric
approved these changes
Nov 25, 2024
Merged
jpwilliams
pushed a commit
that referenced
this pull request
Nov 25, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## inngest@3.26.3 ### Patch Changes - [#758](#758) [`8af4c25`](8af4c25) Thanks [@jpwilliams](https://github.com/jpwilliams)! - Fix OpenAI `tools` types - not properly scoped - [#757](#757) [`36b61f0`](36b61f0) Thanks [@jpwilliams](https://github.com/jpwilliams)! - Fix false indeterminate function warning - [#756](#756) [`7916c06`](7916c06) Thanks [@jpwilliams](https://github.com/jpwilliams)! - Expose a type that lists the `AiAdapter` for each format Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a false indeterminate function warning when using edited inputs in step state.
We show this warning when finding a brand new step that the Executor doesn't yet know about. If we've found this and there's a difference between the number of steps we've previously found and the amount of steps the Executor has given us, we display the warning.
The value we used for these counts was the
fulfilledboolean, which tracks whether a step will resolve or reject based on Executor state. This, however, doesn't account for known steps when the Executor provides aninputinstead.This PR adds a small
hasStepStateboolean to each found step, such that we know if the Executor has any knowledge of the step without scoping it down to just resolve/reject.Checklist
Added a docs PR that references this PRN/A Bug fixAdded unit/integration testsN/A Warning logRelated
step.ai.wrap()editing #748