patch in support overloaded input types on create tool #772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously for wrapped function calls like this with overloaded input types, typescript would throw errors because our generic input type were not seeing all the overloads:
This patches in, somewhat dumbly, support for a few more additional overload types. This makes the above and any wrapped function call with up to 4 overloads work. I haven't found any generic way to support n input overloads.
Note: seems this is not ts backwards compatible.
Checklist
Related