Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nuxt and H3 use https when no NODE_ENV #773

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Conversation

amh4r
Copy link
Contributor

@amh4r amh4r commented Dec 7, 2024

Summary

Fix the SDK reporting its scheme as https when the NODE_ENV env var isn't set.

@amh4r amh4r requested a review from jpwilliams December 7, 2024 01:07
Copy link

changeset-bot bot commented Dec 7, 2024

🦋 Changeset detected

Latest commit: 928ab83

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
inngest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@inngest-release-bot inngest-release-bot added the 📦 inngest Affects the `inngest` package label Dec 7, 2024
@amh4r amh4r added the prerelease/inngest Create snapshot releases for a PR for the "inngest" package. label Dec 7, 2024
@inngest-release-bot
Copy link
Collaborator

inngest-release-bot commented Dec 7, 2024

A user has added the prerelease/inngest label, so this PR will be published to npm with the tag pr-773. It will be updated with the latest changes as you push commits to this PR.

You can install this prerelease version with:

npm install inngest@pr-773

The last release was built and published from 928ab83.

Copy link
Member

@jpwilliams jpwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jpwilliams jpwilliams merged commit fb745ef into main Dec 9, 2024
50 checks passed
@jpwilliams jpwilliams deleted the fix-nuxt-h3-https-dev branch December 9, 2024 16:54
jpwilliams pushed a commit that referenced this pull request Dec 9, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## inngest@3.27.5

### Patch Changes

- [#773](#773)
[`fb745ef`](fb745ef)
Thanks [@amh4r](https://github.com/amh4r)! - Fix Nuxt and H3 uses https
in dev

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 inngest Affects the `inngest` package prerelease/inngest Create snapshot releases for a PR for the "inngest" package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants