Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix w3c validator errors #161

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix w3c validator errors #161

wants to merge 5 commits into from

Commits on Mar 10, 2016

  1. Add charset definition to HTML pages 

    Specifying the charset prevents the browser from guessing the charset to
use.

Relates to innoq#130.
    @mvitz
    mvitz committed Mar 10, 2016
    Configuration menu
    Copy the full SHA
    0236344 View commit details
    Browse the repository at this point in the history

  2. Add nav HTML element 

    Instead of a header with role navigation now the HTML5 element nav is
used.

Relates to innoq#130.
    @mvitz
    mvitz committed Mar 10, 2016
    Configuration menu
    Copy the full SHA
    d4106bf View commit details
    Browse the repository at this point in the history

  3. Remove link from preferences 

    Removes warnings from w3c validator that label and input are not valid
inside an a element. Because preferences aren't links anyway this
increases semantic as well.

Relates to innoq#130.
    @mvitz
    mvitz committed Mar 10, 2016
    Configuration menu
    Copy the full SHA
    0b4b85e View commit details
    Browse the repository at this point in the history

  4. Remove id attribute from hidden _method form field. 

    By default hiccup generates an id for every form field. In our case
(more than one form with method DELETE on the same page) this leads to
non unique ids which leads to w3c validation errors.

Relates to innoq#130.
Workaround for weavejester/hiccup#109.
    @mvitz
    mvitz committed Mar 10, 2016
    Configuration menu
    Copy the full SHA
    53a0804 View commit details
    Browse the repository at this point in the history

  5. Fix form inside of span element. 

    Only inline elements may be contained whithin inline elements. Because
form is not an inline element this leads to w3c validation errors.

Relates to innoq#130.
    @mvitz
    mvitz committed Mar 10, 2016
    Configuration menu
    Copy the full SHA
    d477a31 View commit details
    Browse the repository at this point in the history