-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fastdom to batch reads and writes to the DOM #170
add fastdom to batch reads and writes to the DOM #170
Conversation
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
I noticed that a new bug is introduced by this change, all markers flicker once on the dragEnd event. Have tried to find the cause of this without luck. IMO the performance is worth the small annoyance that the flicker causes but it would be best to find and remove the bug as well. |
It's obviously less than ideal but if you can't fix the flicker can you at least share a reproduction so we can have that documented? You can fork this sandbox and point it at your fork/branch: |
Here is a reproduction of the flicker. https://codesandbox.io/p/sandbox/hardcore-pike-9dcgzn |
OK this is more noticeable than I had hoped. I'll accept the PR for now but it will have to wait for a fix before we can release it. Might have to put it behind a |
Thanks for the contribution @halvtomat! |
Add fastdom to increase customMarker performance by batching DOM reads and writes.
Original PR #163
Closes #162