Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to angular13 + update all other deps #68

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

bboehm86
Copy link
Contributor

Noteworthy:

  • clean up unused deps
  • move from tslint to eslint
  • update to latest jest + migrate config
  • update countup.js to 2.0.8

Info
You should remove the "ngx-countup" entry from the transformIgnorePatterns in the jest.config.js once the version in the root package.json is up-to-date.

closes #66

Noteworthy:
* clean up unused deps
* move from tslint to eslint
* update to latest jest + migrate config
* update countup.js to 2.0.8
@inorganik
Copy link
Owner

this looks like a great PR! Thanks I'll take a look very soon.

Copy link
Owner

@inorganik inorganik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you added jest - but there are no specs. In this case of this lib I don't think it's really necessary. Did you have some tests in mind?

@bboehm86
Copy link
Contributor Author

I see you added jest - but there are no specs. In this case of this lib I don't think it's really necessary. Did you have some tests in mind?

I just updated jest with the rest, it was already there and I didn’t want to leave it broken… but no I don’t think there ist much potential for tests here :)

@inorganik inorganik merged commit 846998a into inorganik:master Feb 14, 2022
@inorganik
Copy link
Owner

Merged, plus I updated the version and published on npm. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular 13
2 participants