Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: rollback supported version to YouTube 19.16.39 #2241

Closed
5 tasks done
inotia00 opened this issue Jul 14, 2024 · 12 comments
Closed
5 tasks done

suggestion: rollback supported version to YouTube 19.16.39 #2241

inotia00 opened this issue Jul 14, 2024 · 12 comments
Labels
Suggestion Leave any other suggestions

Comments

@inotia00
Copy link
Owner

Application

YouTube

Suggestion description

Currently, the RVX patch supports all versions up to YouTube 19.28.xx. (dev branch)

Most users will not encounter any bugs associated with the YouTube version.

Google is conducting A/B testing on a subset of users, and the patch will not work for users in A/B testing.

Here are some cases where patches don't work due to A/B testing:

  1. bug (YouTube): Navigation bar elements is not hiding, when they have new icons  #2169
  2. bug(YouTube/Hide feed components): Hide expandable chip under videos setting does not work #2173
  3. bug(YouTube - Hide Shorts components): not working on home page #2221
  4. bug(YouTube/Enable gradient loading screen): patch not working properly #2224
  5. bug(YouTube/Theme): theme is broken in home feed #2234

This is not a bug that is reproduced by all users, only by some users in A/B testing.
(ofc these are bugs that cannot be reproduced on my side)

If there were only a few bugs caused by A/B testing, it wouldn't be a big issue, but in reality, too many patches are broken due to A/B testing.

For this reason, I will bump the YouTube version when A/B testing is fully completed and new features have been rolled out widely (to most users).

In the next release, supported YouTube versions will be rolled back to 19.16.39.

Users can still patch to the latest YouTube versions, including YouTube 19.28.xx, but no support, including bug reports, will be provided in this case.

Acknowledgements

  • This issue is not a duplicate of an existing suggestion.
  • This is not a feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@inotia00 inotia00 added the Suggestion Leave any other suggestions label Jul 14, 2024
inotia00 added a commit to inotia00/revanced-patches that referenced this issue Jul 14, 2024
@KobeW50
Copy link
Contributor

KobeW50 commented Jul 14, 2024

Will you be implementing the Change version code patch as a universal patch when dropping support for these YT versions?

#2229

@inotia00
Copy link
Owner Author

Oh, I've been so busy lately that I forgot to merge it
It will be applied in the next release

@Sam101011
Copy link

Sam101011 commented Jul 14, 2024

So, it turns out sticking to 19.16.39 was the right descision, albeit for the seekbar thumbnails and not for the reasons mentioned above

@inotia00
Copy link
Owner Author

reflected in revanced-patches-4.10.2

@inotia00 inotia00 changed the title suggestion: drop support for YouTube 19.25.39+ suggestion: rollback supported version to YouTube 19.16.39 Jul 17, 2024
@alcatraz-zz
Copy link

I'm on 4.10.2 and 19.16.xx now and I lost 4k resolutions on my phone. They were working fine. Is that normal?

@Aryan-Chauhan
Copy link

I'm on 4.10.2 and 19.16.xx now and I lost 4k resolutions on my phone. They were working fine. Is that normal?

Make sure of 2 things:

  1. Spoof client should be set to anything other than iOS.

  2. Spoof Device Dimensions should be enabled.

@Tiebe
Copy link

Tiebe commented Jul 27, 2024

This has caused it to stop working on the Android 15 beta, as the system installed version is higher than 19.16.39 (19.17.42). I'll be changing my version manually for now, but just something you should be aware of!

@alcatraz-zz
Copy link

alcatraz-zz commented Jul 27, 2024

This has caused it to stop working on the Android 15 beta, as the system installed version is higher than 19.16.39 (19.17.42). I'll be changing my version manually for now, but just something you should be aware of!

Although I haven't tried it, there's a developer called Anddea that also provides RvX patches. Currently his RvX is based off of 19.23.xx. That might work for you in the meantime.

@BAXSD
Copy link

BAXSD commented Aug 2, 2024

How long will YouTube do this A/B testing so we would be able to patch newer versions of YouTube?

@akash07k
Copy link

Can you please provide the link to his builds? I can't find.

This has caused it to stop working on the Android 15 beta, as the system installed version is higher than 19.16.39 (19.17.42). I'll be changing my version manually for now, but just something you should be aware of!

Although I haven't tried it, there's a developer called Anddea that also provides RvX patches. Currently his RvX is based off of 19.23.xx. That might work for you in the meantime.

@KobeW50
Copy link
Contributor

KobeW50 commented Oct 22, 2024

@akash07k https://github.com/anddea/revanced-patches/

anddea has also rolled back to v19.16.39.

Inotia00s patches should still work (for the most part) on newer unsupported versions, so you can use them if you need (just dont submit bug reports).

The good news is that inotia00 has said that (on Discord) that the supported version will likely be bumped before the end of the year.

@akash07k
Copy link

Oh, ok. sadly 2 months are still remaining before the end of the year :-)

@akash07k https://github.com/anddea/revanced-patches/

anddea has also rolled back to v19.16.39.

Inotia00s patches should still work (for the most part) on newer unsupported versions, so you can use them if you need (just dont submit bug reports).

The good news is that inotia00 has said that (on Discord) that the supported version will likely be bumped before the end of the year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Suggestion Leave any other suggestions
Projects
None yet
Development

No branches or pull requests

8 participants