ci: Use semi-transparent Discord embed color #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 18, 2024
This was referenced Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it so that the accent color of Discord embeds will be semi-transparent (and therefore follow the user's theme) instead of opaque RVX-red. The rest of the embeds in the server use the semi-transparent color because it is easier on the eyes and looks more professional.
This image shows the difference:
The semi-transparent color is displayed when the
colorfield in the payload JSON is undefined or set tonull. Unfortunately, the GitHub action that this workflow uses does not allow you to simply leave thecolorfield undefined or set tonull. (If this is attempted, the color will default to green for some reason). To get around this, the creator of the GitHub action added the ability to generate the payload without sending it, which allows you to edit it and then send it afterward.See sarisia/actions-status-discord#547 for further discussion.