-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(elements|ino-nav-drawer): implement mobile nav-drawer #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiasHeimGalindo
temporarily deployed
to
github-pages
August 3, 2023 12:30
— with
GitHub Actions
Inactive
TobiasHeimGalindo
temporarily deployed
to
github-pages
August 4, 2023 11:18
— with
GitHub Actions
Inactive
TobiasHeimGalindo
temporarily deployed
to
github-pages
August 9, 2023 11:00
— with
GitHub Actions
Inactive
TobiasHeimGalindo
changed the title
feat(elements|ino-nav-drawer): implement mobile nav-drawer
Draft: feat(elements|ino-nav-drawer): implement mobile nav-drawer
Aug 11, 2023
TobiasHeimGalindo
changed the title
Draft: feat(elements|ino-nav-drawer): implement mobile nav-drawer
feat(elements|ino-nav-drawer): implement mobile nav-drawer
Aug 11, 2023
TobiasHeimGalindo
force-pushed
the
elements-#1010-add-mobile-nav-drawer
branch
from
August 11, 2023 09:59
96d113c
to
5391e85
Compare
MariaLStefan
requested changes
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done 👌
Just some optimizations
packages/elements/src/components/ino-nav-drawer/ino-nav-drawer.tsx
Outdated
Show resolved
Hide resolved
packages/elements/src/components/ino-nav-drawer/ino-nav-drawer.tsx
Outdated
Show resolved
Hide resolved
packages/elements/src/components/ino-nav-drawer/ino-nav-drawer.scss
Outdated
Show resolved
Hide resolved
TobiasHeimGalindo
temporarily deployed
to
github-pages
September 1, 2023 10:34
— with
GitHub Actions
Inactive
TobiasHeimGalindo
temporarily deployed
to
github-pages
September 5, 2023 09:47
— with
GitHub Actions
Inactive
janivo
requested changes
Sep 12, 2023
packages/elements/src/components/ino-nav-drawer/ino-nav-drawer.tsx
Outdated
Show resolved
Hide resolved
packages/elements/src/components/ino-nav-drawer/ino-nav-drawer.tsx
Outdated
Show resolved
Hide resolved
janivo
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1010
4032d1ad8c633fd429d8e7bc5077cf2d.mp4