Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(elements|ino-nav-drawer): implement mobile nav-drawer #1035

Merged
merged 11 commits into from
Sep 28, 2023

Conversation

TobiasHeimGalindo
Copy link
Collaborator

@TobiasHeimGalindo TobiasHeimGalindo commented Aug 3, 2023

Closes #1010

4032d1ad8c633fd429d8e7bc5077cf2d.mp4

@TobiasHeimGalindo TobiasHeimGalindo temporarily deployed to github-pages August 3, 2023 12:30 — with GitHub Actions Inactive
@TobiasHeimGalindo TobiasHeimGalindo temporarily deployed to github-pages August 4, 2023 11:18 — with GitHub Actions Inactive
@TobiasHeimGalindo TobiasHeimGalindo marked this pull request as ready for review August 9, 2023 10:55
@TobiasHeimGalindo TobiasHeimGalindo temporarily deployed to github-pages August 9, 2023 11:00 — with GitHub Actions Inactive
@TobiasHeimGalindo TobiasHeimGalindo changed the title feat(elements|ino-nav-drawer): implement mobile nav-drawer Draft: feat(elements|ino-nav-drawer): implement mobile nav-drawer Aug 11, 2023
@TobiasHeimGalindo TobiasHeimGalindo marked this pull request as draft August 11, 2023 09:43
@TobiasHeimGalindo TobiasHeimGalindo changed the title Draft: feat(elements|ino-nav-drawer): implement mobile nav-drawer feat(elements|ino-nav-drawer): implement mobile nav-drawer Aug 11, 2023
@TobiasHeimGalindo TobiasHeimGalindo force-pushed the elements-#1010-add-mobile-nav-drawer branch from 96d113c to 5391e85 Compare August 11, 2023 09:59
@TobiasHeimGalindo TobiasHeimGalindo marked this pull request as ready for review August 11, 2023 10:10
Copy link
Collaborator

@MariaLStefan MariaLStefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done 👌
Just some optimizations

@TobiasHeimGalindo TobiasHeimGalindo temporarily deployed to github-pages September 1, 2023 10:34 — with GitHub Actions Inactive
@TobiasHeimGalindo TobiasHeimGalindo temporarily deployed to github-pages September 5, 2023 09:47 — with GitHub Actions Inactive
@janivo janivo merged commit 5617375 into master Sep 28, 2023
6 checks passed
@janivo janivo deleted the elements-#1010-add-mobile-nav-drawer branch September 28, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a mobile version of our nav-drawer
3 participants