Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(landingpage): tweak navigation design #1045

Merged
merged 7 commits into from
Sep 7, 2023

Conversation

TobiasHeimGalindo
Copy link
Collaborator

@TobiasHeimGalindo TobiasHeimGalindo commented Aug 16, 2023

Closes #995

Proposed Changes

Video.mp4

BenPag
BenPag previously approved these changes Aug 17, 2023
BingeCode
BingeCode previously approved these changes Aug 17, 2023
Copy link
Collaborator

@BingeCode BingeCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're already tweaking some things about the navigation, here's two more things that could be improved (perhaps in another story):

  1. Add padding and hover effect to the menu items so that it's easier to click them (see inovex.de homepage for reference)
  2. Navigation items without sub menu should not have a context menu pop up. IMO inovex.de handles that elegantly by underlining those navigation items (picture 2)
image image

@TobiasHeimGalindo
Copy link
Collaborator Author

Since we're already tweaking some things about the navigation, here's two more things that could be improved (perhaps in another story):

  1. Add padding and hover effect to the menu items so that it's easier to click them (see inovex.de homepage for reference)
  2. Navigation items without sub menu should not have a context menu pop up. IMO inovex.de handles that elegantly by underlining those navigation items (picture 2)

image image

@BingeCode sounds and looks good. I will implement this in this PR

@TobiasHeimGalindo TobiasHeimGalindo marked this pull request as draft August 17, 2023 10:54
@TobiasHeimGalindo TobiasHeimGalindo marked this pull request as ready for review August 18, 2023 09:43
BingeCode
BingeCode previously approved these changes Sep 7, 2023
Copy link
Collaborator

@BingeCode BingeCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!
I also noticed that the navbar doesn't toggle to mobile view at the correct breakpoint - it extends further than the viewport allows. Same for the rest of the landingpage, perhaps this should be tackled in a separate story

@janivo janivo enabled auto-merge (squash) September 7, 2023 13:45
@janivo janivo merged commit c1279b6 into master Sep 7, 2023
4 of 5 checks passed
@janivo janivo deleted the elements-#995-tweak-navigation-design branch September 7, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tweak navigation design
4 participants