-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(landingpage): tweak navigation design #1045
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're already tweaking some things about the navigation, here's two more things that could be improved (perhaps in another story):
- Add padding and hover effect to the menu items so that it's easier to click them (see inovex.de homepage for reference)
- Navigation items without sub menu should not have a context menu pop up. IMO inovex.de handles that elegantly by underlining those navigation items (picture 2)
@BingeCode sounds and looks good. I will implement this in this PR |
17b70dc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice!
I also noticed that the navbar doesn't toggle to mobile view at the correct breakpoint - it extends further than the viewport allows. Same for the rest of the landingpage, perhaps this should be tackled in a separate story
# Conflicts: # packages/landingpage/components/layout/header/desktop/navbar.tsx
Closes #995
Proposed Changes
Video.mp4