chore: upgrade stencil & migrate from vue-cli to vite #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janivo
force-pushed
the
test-yarn-lock-update
branch
from
501e82b
to
42e383f
Compare
janivo
changed the title
janivo
changed the title
BingeCode
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #871
Changes to combat CI issues.
Problem was some cryptic error in our pipeline within the
elements-vue-examplebuild process:This error occurred in all of our PRs as well as in the
masterbranch but not locally.Initially, I suspected that the issue might be related to the yarn.lock file. Deleting and rebuilding it did not resolve the problem.
Subsequently, I considered the possibility of a problem related to Stencil. To address this, I upgraded Stencil from version 2.x to the latest version 4.4. Unfortunately, this upgrade did not resolve the error in the pipeline. During this process, I also took the opportunity to update some other dependencies, including React, NX, and Vite. Additionally, I made some changes to the stencil configuration and the Angular Output Target. These changes brought the syntax of the Angular Output Target in line with that of the Vue Output Target, eliminating the need for our previously hand-written ValueAccessors.
Finally, I speculated that the deprecated Vue-CLI might be causing the issue. To test this theory, I replaced Vue-CLI with Vite, and it appears that the issue has been resolved.