Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(elements|ino-select): update on ino-option change #520

Merged
merged 3 commits into from
Feb 16, 2022
Merged

fix(elements|ino-select): update on ino-option change #520

merged 3 commits into from
Feb 16, 2022

Conversation

BenPag
Copy link
Collaborator

@BenPag BenPag commented Feb 14, 2022 •
edited
Loading

Closes #418 , #366 , #480

Proposed Changes

  • use MutationObserver to watch changes and force redener if necessary

Things to check

  • Does the change need to be documented?
  • Does any existing example code needs to be updated?
  • Is the change properly tested?
  • Is it helpful to provide another example to demonstrate the new feature?
  • Are there other code lines that need to be modified?

@BenPag BenPag changed the title Elements 418,366 ino select fix dynamic content fix(elements|ino-select): support dynamic content change Feb 14, 2022
@silentHoo silentHoo linked an issue Feb 15, 2022 that may be closed by this pull request
Improve select behavior on dynamic option changes #480
Closed
@BenPag BenPag linked an issue Feb 15, 2022 that may be closed by this pull request
elements-angular|ino-select: Dynamic content not rendered/updated #366
Closed
@janivo janivo changed the title fix(elements|ino-select): support dynamic content change fix(elements|ino-select): update on ino-option change Feb 16, 2022
@janivo janivo merged commit 43c56b6 into master Feb 16, 2022
@janivo janivo deleted the elements-418,366-ino-select-fix-dynamic-content branch February 16, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janivo janivo janivo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@BenPag @janivo