refactor(elements|ino-popover): implement new design #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add tooltip-base stylesheet - add colorSchemes dark, light, primary
- add tippy themes `light`, `dark` & `primary` - add arrow to tippy instance
- implement basic design (no headline) - redefine arrow shadow
- add styled-popover story - change colorSchema story to contain all colors - align button left for placement story - define height for stories & align buttons on flex-end of story
MariaLStefan
changed the title
- add story for `headerText` prop - remove styledPopover story - update styling for `ino-popover` with `headerText`
- remove headerText Story - add default Slot Story
Sl1nd
reviewed
Aug 4, 2023
Sl1nd
reviewed
Aug 4, 2023
…sign # Conflicts: # packages/elements/src/components.d.ts # packages/elements/src/components/types.ts # packages/landingpage-new/pages/[lang]/library/components/index.module.scss # packages/landingpage-new/pages/[lang]/library/components/index.tsx # packages/landingpage/public/open-in-new.svg # packages/landingpage/utils/hooks/useStorybookUrl.ts
janivo
previously approved these changes
Sep 7, 2023
janivo
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #959