refactor(storybook): use new stylesheet for storybook #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- sidebar item background - toolbar selected icon
MariaLStefan
temporarily deployed
to
github-pages
GitHub Actions
Inactive
BingeCode
reviewed
Jun 29, 2023
| .os-content .sidebar-subheading { | ||
| /* Title Small */ | ||
| letter-spacing: 0.02px; | ||
| font-weight: 600; | ||
| color: #CBD0E0; /* n-6 */ | ||
| color: var(--inovex-elements-n-3); |
There was a problem hiding this comment.
Why did you pick n-3 over the previous n-6? It's quite a light contrast to the background. I think n-6 would be better, perhaps even higher - for accessibility and general readability.
n-3:
n-6:
BingeCode
reviewed
Jun 29, 2023
| @@ -70,56 +73,71 @@ | |||
| transition: 0.15s ease-in-out; | |||
| } | |||
|
|
|||
| .os-content .sidebar-item button[data-selected="true"] { | |||
| background-color: rgb(var(--inovex-elements-n-3)) !important; | |||
There was a problem hiding this comment.
Overriding styles with !important is always risky. It makes it difficult to override this style at a later point. Is there really no way to reach higher rule specifity with css selectors / import ordering?
BingeCode
requested changes
Jun 29, 2023
- for readability - styling for toolbar buttons
janivo
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #965
Proposed Changes