fix(loadQuickDiff): altered-clicking on a link should open it in a new tab #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
建议能不引入外部依赖就不引入（ |
|
附议 |
|
我看了下依赖的源码，应该是可以直接展开出来的 |
|
既然看过了，那就应该看到了依赖里面其实也只是一个if块，显然不会增加什么体积。 有现成的不直接引，转而自己照着写一个一样的放源码里，变成自己的东西，是什么奇怪的坚持呢。 补充：这只是对于这个依赖来说的。自己写一段一样的放里面和引一个现成的没什么区别，无外乎就是搓了一个新轮子。其他体积大的依赖项但只用到了其中一个/几个方法的另当别论。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #241