-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DDEV Config #29
Add DDEV Config #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Can't say much about the actual correctness or usefulness of this PR, though.
Left a couple of nitpicky comments. Also, do we really need .idea/
version-controlled? For other projects/packages, we never do this.
Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com> Signed-off-by: Moritz Meißelbach <arbelzapf@gmail.com>
Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com> Signed-off-by: Moritz Meißelbach <arbelzapf@gmail.com>
Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com> Signed-off-by: Moritz Meißelbach <arbelzapf@gmail.com>
This discussion comes up every now and then. Apart from occasional "side-effects" in PR (when a settings change potentially sneaks into some feature branch), this does not seem to have downsides. The benefits are:
For projects the benefits seem to vastly outweigh any downsides. For libraries, it is often not as useful because you usually simply "don't xdebug as hard" there. But since this is a "library-turned-project" now and this PR aims to provide a "Press button, receive working WP dev env" config, I felt it makes sense to ship the complementary IDE settings as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation. Makes sense.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Development environment
What is the current behavior? (You can also link to an open issue here)
There is no local dev environment provided by this repository, making it a bit cumbersome to work with in isolation
What is the new behavior (if this is a feature change)?
A full DDEV config is provided, containing orchestration logic for a basic WP-Stash-enabled WordPress instance
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information: