-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/e2e #31
Merged
Merged
Feat/e2e #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # wp-stash-test-plugin/wp-stash-test-plugin.php
tyrann0us
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com> Signed-off-by: Moritz Meißelbach <arbelzapf@gmail.com>
Biont
added a commit
that referenced
this pull request
Jun 16, 2023
* WIP Add new core functions * Implement new core functions * Code Style * Revert accidental switch of DDEV project type * Fix cache key handling * Fix cache key handling * Fix code style * Fixes and improvements * Fixes code style * Feat/e2e (#31) * Add Playwright e2e testing * Add Playwright e2e testing * Fix test plugin not being handled correctly during orchestration * Remove note about unimplemented tests * Update wp-stash-test-plugin/template.php Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com> Signed-off-by: Moritz Meißelbach <arbelzapf@gmail.com> * Remove unneeded workflow boilerplate * Remove unneeded playwright config --------- Signed-off-by: Moritz Meißelbach <arbelzapf@gmail.com> Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com> --------- Signed-off-by: Moritz Meißelbach <arbelzapf@gmail.com> Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
testing
What is the current behavior? (You can also link to an open issue here)
New functions have been added without a proper way to test them in an actual application environment.
Isolated tests are not sufficient for infrastructure packages like this
What is the new behavior (if this is a feature change)?
E2E-Testing via Playwright is added. A helper plugin is provided in the orchestration to deal with structured front-end output
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information: