Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/e2e #31

Merged
merged 9 commits into from
Jun 16, 2023
Merged

Feat/e2e #31

merged 9 commits into from
Jun 16, 2023

Conversation

Biont
Copy link
Member

@Biont Biont commented Jun 15, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
testing

What is the current behavior? (You can also link to an open issue here)
New functions have been added without a proper way to test them in an actual application environment.
Isolated tests are not sufficient for infrastructure packages like this

What is the new behavior (if this is a feature change)?
E2E-Testing via Playwright is added. A helper plugin is provided in the orchestration to deal with structured front-end output

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:

@Biont Biont marked this pull request as ready for review June 16, 2023 07:45
Copy link
Member

@tyrann0us tyrann0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.ddev/commands/playwright/playwright Show resolved Hide resolved
.github/workflows/playwright.yml Outdated Show resolved Hide resolved
tests/Playwright/playwright.config.js Outdated Show resolved Hide resolved
wp-stash-test-plugin/template.php Outdated Show resolved Hide resolved
Biont and others added 4 commits June 16, 2023 12:22
Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>
Signed-off-by: Moritz Meißelbach <arbelzapf@gmail.com>
@Biont Biont merged commit 8488c97 into feat/support-new-core-functions Jun 16, 2023
@Biont Biont deleted the feat/e2e branch June 16, 2023 13:05
Biont added a commit that referenced this pull request Jun 16, 2023
* WIP Add new core functions

* Implement new core functions

* Code Style

* Revert accidental switch of DDEV project type

* Fix cache key handling

* Fix cache key handling

* Fix code style

* Fixes and improvements

* Fixes code style

* Feat/e2e (#31)

* Add Playwright e2e testing

* Add Playwright e2e testing

* Fix test plugin not being handled correctly during orchestration

* Remove note about unimplemented tests

* Update wp-stash-test-plugin/template.php

Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>
Signed-off-by: Moritz Meißelbach <arbelzapf@gmail.com>

* Remove unneeded workflow boilerplate

* Remove unneeded playwright config

---------

Signed-off-by: Moritz Meißelbach <arbelzapf@gmail.com>
Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>

---------

Signed-off-by: Moritz Meißelbach <arbelzapf@gmail.com>
Co-authored-by: Philipp Bammes <8144115+tyrann0us@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants