Restructuring Package::hasReachedStatus()

Co-authored-by: Thorsten Frommen <info@tfrommen.de> Signed-off-by: Giuseppe Mazzapica <giuseppe.mazzapica@gmail.com>
inpsyde · Aug 29, 2024 · 657ed77 · 657ed77
1 parent 0d97bbe
commit 657ed77
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/Package.php b/src/Package.php
@@ -653,11 +653,11 @@ public function hasFailed(): bool
      */
     public function hasReachedStatus(int $status): bool
     {
-        if (!isset(self::SUCCESS_STATUSES[$status])) {
+        if ($this->hasFailed()) {
             return false;
         }
 
-        return !$this->hasFailed() && $this->checkStatus($status, '>=');
+        return isset(self::SUCCESS_STATUSES[$status]) && $this->checkStatus($status, '>=');
     }
 
     /**