Fix PHPUnit tests not running in CI and failing test #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #37 +/- ##
============================================
+ Coverage 95.90% 98.86% +2.95%
- Complexity 170 189 +19
============================================
Files 9 9
Lines 464 528 +64
============================================
+ Hits 445 522 +77
+ Misses 19 6 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
tfrommen
approved these changes
Nov 3, 2023
|
Thanks for your work ☕ Good catch! 💪🏻 |
auto-merge was automatically disabled
November 3, 2023 20:16
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
It fixes a failing test and the CI where PHPUnit tests are not actually run.
What is the current behavior? (You can also link to an open issue here)
There's a failing test, but that is never caught because the PHPUnit tests are not run.
What is the new behavior (if this is a feature change)?
PHPUnit runs again in the CI, and the failing test passes.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.
Other information:
None.