Minimal necessary tracking of governance actions and SPD (MS5.1)

[buddhisthead]

Summary

Minimal necessary tracking of governance actions, stake distribution, reward accounts to derive Stake Pool Distribution

Intersect Milestone

MS5.1

Description

"Create modules that minimally track governance actions, stake distribution, and reward accounts necessary for deriving accurate Stake Pool Distribution (SPD) from replay and ongoing following of the Cardano mainnet"

This is essentially the entire set of ledger state modules, leading to AccountsState which creates the SPDD. Because governance actions are implicated in the SPDD (through return of deposits to reward accounts), comparing the SPDD is sufficient test for all of it.

Acceptance Criteria

"Derived SPD matches that produced by the Haskell node"

Implicitly this is for a reasonable current epoch. We need to verify that our SPDD matches that produced by the Haskell node (e.g. simple comparison of a CSV file - see #390 ), and also that the reserves & treasury pots are correct. There is existing automatic checking for the pots in AccountsState, but the test data will need to be brought up to date.

Expected Deliverables

• "Implementation of modules to track stake, governance and rewards and deriving Stake Pool Distribution"

All the modules exist, we believe only the reward calculation for early epochs is at fault. Booting from snapshot into the relatively sane world of Conway will avoid that issue, or at least make any fixes required much clearer.

• "Report validating correctness and efficiency of SPD derivation."

One-pager report giving methodology of extraction of SPDD from Haskell and comparison with ours showing no differences.

[buddhisthead]

@shd I didn't make this an Epic, but it's easy to change if you wish. Since it's labeled already as "Minimal" I thought we'd make a new ticket for the remaining implementation of correctness after this is complete. This ticket is very specific to the MAF milestone MS5.1

[shd]

1. Modules for tracking stake, governance and rewards are already implemented.
2. Correctness of SPD distribution should be checked

[buddhisthead]

@shd is this still in progress? What needs to be done to move this forward?

[sandtreader]

Description updated to flesh out deliverables.

Moved comment giving current status:

NOTE: Correctness is already valid up to Epoch 213, with Governance correct up to Epoch 575.

@shd will revalidate the governance part. Reward divergence at epoch 214 is covered in #414