ChainStore module #138
Open
ChainStore module #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SupernaviX
force-pushed
the
sg/chain-store
branch
from
ac5689b to
2c21d6b
Compare
- Doesn't serialise byte arrays correctly yet
- blocks/{hash_or_number} endpoint added
- blocks/slot/{slot_number} endpoint added
- blocks/epoch/{epoch_number}/slot/{slot_number} endpoint added
- add missing hash field to block info output
- also stub out addresses endpoint
- used to match for non-SPO issuers - builds, but probably doesn't work yet
- also add some macros to help make these types easily
sandtreader
reviewed
Oct 16, 2025
| pallas-addresses = "0.33.0" | ||
| pallas-crypto = "0.33.0" | ||
| pallas-primitives = "0.33.0" | ||
| pallas-traverse = "0.33.0" |
There was a problem hiding this comment.
Only just noticed these were already workspace dependencies on Pallas... Can we avoid this? I was hoping if we didn't expose Pallas in any common/ interfaces we could protect modules from this dependency unless they absolutely need it.
| RolledBack, // Volatile, restarted after rollback | ||
| } | ||
|
|
||
| macro_rules! declare_byte_array_type { |
There was a problem hiding this comment.
Think this should be split out, as discussed generally
|
|
||
| macro_rules! declare_byte_array_type_with_bech32 { | ||
| ($name:ident, $size:expr, $hrp:expr) => { | ||
| declare_byte_array_type!($name, $size); |
There was a problem hiding this comment.
Yay, inheritance in Rust ;-)
| } | ||
|
|
||
| /// Handle `/blocks/latest`, `/blocks/{hash_or_number}` | ||
| pub async fn handle_blocks_latest_hash_number_blockfrost( |
There was a problem hiding this comment.
Given this is in a rest_blockfrost module, do we need all these _blockfrost suffixes?
There was a problem hiding this comment.
I don't think we do, but I was maintaining consistency with the other functions in the crate
- rest_query_state is essentially query_state that returns RESTResponse, and handles the common error cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP