feat: account assets REST endpoint #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Hankins <william@sundae.fi>
Signed-off-by: William Hankins <william@sundae.fi>
Signed-off-by: William Hankins <william@sundae.fi>
Signed-off-by: William Hankins <william@sundae.fi>
Signed-off-by: William Hankins <william@sundae.fi>
Signed-off-by: William Hankins <william@sundae.fi>
Signed-off-by: William Hankins <william@sundae.fi>
lowhung
approved these changes
Nov 8, 2025
|
|
||
| for block_map in drained_blocks { | ||
| for (addr, entry) in block_map { | ||
| let target = merged.entry(addr.clone()).or_insert_with(MergedDeltas::default); |
Collaborator
There was a problem hiding this comment.
Why do we insert defaults as our fallback here?
Collaborator
Author
There was a problem hiding this comment.
This is to populate an empty entry for an address if the current block delta is the first time the address is detected in the epoch.
golddydev
approved these changes
Nov 10, 2025
Signed-off-by: William Hankins <william@sundae.fi>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the
/accounts/{stake_address}/addresses/assetsendpoint. It also refactors theImmutableAddressStoreto merge block deltas in memory before persistence, fixing a bug where UTxOs spent in the same epoch they were created not being removed correctly.Related Issue(s)
#256 & #335
How was this tested?
Compared REST responses against Blockfrost using accounts with long standing balances such as stake1u88...cq5e4eww.
The handler itself serves as a runtime correctness test. The query fails if
address_statereturns any UTxO not found inutxo_state.Checklist
Impact / Side effects
Merging block deltas in memory before persistence reduces DB access frequency, improving sync performance when address UTxO, transaction, or totals indexing is enabled.
Reviewer notes / Areas to focus
Most logic changes are in
modules/address_state/src/immutable_address_store.rs.A known bug in totals persistence (tx count) will be addressed in a follow up PR implementing the
/accounts/{stake_address}/addresses/totalendpoint.