feat: raw bytes transaction handler for indexes with Pallas version conflicts #468
+26
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endent Pallas versions Signed-off-by: William Hankins <william@sundae.fi>
SupernaviX
reviewed
Dec 9, 2025
Comment on lines
23
to
31
| /// Low-level transaction handler that receives raw CBOR bytes. | ||
| /// | ||
| /// The indexer runtime calls this when `wants_raw_bytes() == true`. | ||
| /// Implementors can parse the bytes using their own Pallas versions, | ||
| /// bypass decoding in the runtime, or operate directly on the CBOR. | ||
| async fn handle_onchain_tx_bytes(&mut self, info: &BlockInfo, raw_tx: &[u8]) -> Result<()> { | ||
| let _ = (info, raw_tx); | ||
| Ok(()) | ||
| } |
Collaborator
There was a problem hiding this comment.
What if we make the default implementation of this method parse the bytes itself, and then call its own handle_onchain_tx? Then we don't need wants_raw_bytes
Collaborator
Author
There was a problem hiding this comment.
Updated the default implementation of handle_onchain_tx_bytes to decode and then call handle_onchain_tx in d823216. Thanks for the suggestion!
…bytes Signed-off-by: William Hankins <william@sundae.fi>
SupernaviX
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new
handle_onchain_tx_rawmethod on theChainIndextrait.This allows an index to override tx decoding to process raw bytes rather than a decoded
MultiEraTx. This enables integrations (such as the Scooper) that depend on a different Pallas version than Acropolis. Indexes that do not overridehandle_onchain_tx_rawcontinue using the existing decoded path semantics with no behavior change.Related Issue(s)
Relates to #462
How was this tested?
Checklist
Impact / Side effects
Existing indexes require no changes. Index authors now have explicit control over how transaction decoding is performed, enabling compatibility with custom or conflicting Pallas versions.
Reviewer notes / Areas to focus
handle_apply_txsincustom_indexer/src/index_actor.rs.