Architecture docs and simplified configs #469
Draft
+1,014
−174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diagram link test - other links to be added if it works!
Also fix bad comment re withdrawals
Make some governance subscriptions optional Still blocks on startup, more unplugging needed
We need GovernanceState to update the protocol parameters even in Shelley, but we don't want to include DReps. This makes the DRep and SPO distribution subscriptions optional which allows it to work without them. Also removed the blocks subscription hack from ParameterState since we can now depend on Governance State being available - they come as a couple. Updated docs and configs to suit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Started on a ground-up description of the modules and dataflows, creating example configs for each stage as I go. On
adding the basic ledger one (aiming to avoid governance for now) it turned out we couldn't run without governance. I've
made governance-related subscriptions optional in SPOState and ParameterState.
Related Issue(s)
How was this tested?
Runs successfully up to epoch 215 and generates the same reward result
Checklist
Impact / Side effects
No particular side effects other than there are now subscriptions that have to be made explicit in the config that were previously default. Considering making all subscriptions explicit, and tidying up config mechanism generally.
Reviewer notes / Areas to focus
Feedback on docs - readability, coverage