Shd/validate spdd #470
Merged
Shd/validate spdd #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandtreader
reviewed
Dec 11, 2025
| .map(|(p, e, s)| format!("{p}: eth {e} != comp {s}; ")) | ||
| .collect::<String>(); | ||
| error!( | ||
| "SPDD verificiation epoch {epoch} stake difference: {}", |
sandtreader
reviewed
Dec 11, 2025
| if !different.is_empty() { | ||
| let message = different | ||
| .iter() | ||
| .map(|(p, e, s)| format!("{p}: eth {e} != comp {s}; ")) |
Collaborator
There was a problem hiding this comment.
Could we have newlines in it? Hard to read otherwise
sandtreader
approved these changes
Dec 11, 2025
Collaborator
sandtreader
left a comment
sandtreader
left a comment
There was a problem hiding this comment.
This is great, thanks. Very minor comments on logging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds verification of SPDD, as compared with Haskell output
Related Issue(s)
Fixes #426How was this tested?
Checklist
Impact / Side effects