feat: bootstrap utxo module #484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
December 10, 2025 17:57
- addresses, native assets, datums and reference scripts currently missing values from snapshot
4 tasks
lowhung
reviewed
Dec 14, 2025
- Extract UTXO-related types (SnapshotUTxO, SnapshotUTxOIdentifier, SnapshotAddress, SnapshotValue, SnapshotUTXOValue, UtxoEntry) from streaming_snapshot.rs into new utxo.rs module - Fix utxo_state module not receiving bootstrap UTXOs by adding default subscription to "cardano.snapshot" topic (was previously optional with no default, so subscription never happened) - Change publisher's tokio::spawn to blocking calls using block_in_place + Handle::current().block_on() to ensure messages are published before callbacks return - Add logging for UTXO batch publishing and receiving to aid debugging
# Conflicts: # modules/snapshot_bootstrapper/src/publisher.rs
Collaborator
|
Confirmation of this working |
Closed
4 tasks
buddhisthead
approved these changes
Dec 16, 2025
Collaborator
buddhisthead
left a comment
buddhisthead
left a comment
There was a problem hiding this comment.
Wow, this looks great! So much nice cleanup and nice documentation about the issues.
Note: I initially did have a SnapshotCompleteMessage that marked the end of the boot-from-snapshot process, but found there is already a snapshot complete message. At that time, I didn't realize the order of mithril "snapshot" loading vs our boostrapping. It confused me for a while because there is the Cardano message that means "Mithril snapshot loading complete".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements bootstrapping the UTxO state module from the streaming snapshot.
Related Issue(s)
Implements #386.
How was this tested?
Checklist
Impact / Side effects
Replaces the contents of the UtxoEntry struct with our own common types, so anything else relying on them will need updating. I'm not aware of anything that falls into this scope.
Reviewer notes / Areas to focus
I'm not sure if it's normal to have invalid utxos?
acropolis_module_utxo_state::state: slot=134956948 number=10844342 immutable_utxos=11234442 volatile_utxos=243 valid_utxos=11234421I'm not 100% sure about the address parsing, particularly the "other Shelley" bit where I've assumed that from_bytes_key() is the right thing for everything that isn't a stake address.
The flushing of any final utxo state message batch on completion of the snapshot could do with checking. My understanding from the very helpful comment is that the message sent by on_actions() blocks until all snapshot messages are dealt with, so I have added a call to flush any final batches just before that message is sent.
Sidenote: having a SnapshotComplete message sent on the snapshot channel might provide a cleaner place to hook this into. I think it also provides a simple mechanism for modules to drop their snapshot listeners should we wish to do that.