This repository was archived by the owner on Jun 11, 2022. It is now read-only.
Improve error reporting for some subcommands #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
November 1, 2018 19:31
No deep exits, please, and no pre-guessing errors that Blockchain::load() might encounter.
Not that there are any errors at the moment.
Don't use the language safety feature to designate actions that need user confirmation.
Command "status".
Instead of unwrapping the optional block address, display an alternate text if it is None.
Putting more generic From-able errors up front.
Generalized handling of BIP44 errors, which can also occur in "sync", with a From impl.
NicolasDP
reviewed
Nov 5, 2018
NicolasDP
reviewed
Nov 5, 2018
NicolasDP
approved these changes
Nov 5, 2018
This is some replacement for the former unsafe-as-note-to-ourselves declaration of the method.
NicolasDP
reviewed
Nov 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed deep exits and direct use of
Term::fail_within various places.Mostly centered on the "wallet" subcommand in this PR.