build/no-extraneous-dependencies #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhyslbw
requested review from
mkazlauskas,
mirceahasegan and
a team
and removed request for
mirceahasegan
mkazlauskas
previously approved these changes
Nov 7, 2022
No noticeable difference 🧘 |
rhyslbw
dismissed stale reviews from mirceahasegan and mkazlauskas
via
341b8f0
rhyslbw
force-pushed
the
build/no-extraneous-dependencies
branch
from
373c348 to
341b8f0
Compare
rhyslbw
changed the title
mirceahasegan
previously approved these changes
Nov 7, 2022
rhyslbw
force-pushed
the
build/no-extraneous-dependencies
branch
2 times, most recently
from
75108d9 to
858dcf0
Compare
…pendencies This rule, with the configuration to specify test files, ensures packages used in `src` are listed in the package.json `dependencies`. It will fail if missing or if the dependency is included with `devDependencies`. Development dependencies are checked against the test directories. There's a single disable as it's complaining about transitive dependency on `@types/pg` missing from `dependencies`. We can see if the feature added in import-js/eslint-plugin-import#2543 handles this scenario once released.
rhyslbw
force-pushed
the
build/no-extraneous-dependencies
branch
from
858dcf0 to
35f7fc9
Compare
AngelCastilloB
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We have quite a few issues with the package dependencies, which is not unexpected, given the lack of enforcement and this being such a tedious aspect of maintaining a monorepo with Node.js' inferred dependencies design.
Proposed Solution
This rule, with the configuration to specify test files, ensures packages used in
srcare listed in the package.jsondependencies. It will fail if missing or if the dependency is included withdevDependencies. Development dependencies are checked against the test directories.Important Changes Introduced
There's a single disable as it's complaining about transitive dependency on
@types/pgmissing fromdependencies. We can see if the feature added in import-js/eslint-plugin-import#2543 handles this scenario once released.New similar imports may need to be overruled moving forward, but I only found one case in the whole workspace, so don't expect it to be a frequently occurring situation.