-
Notifications
You must be signed in to change notification settings - Fork 630
[CSL-1002] Link project with gold linker #193
Conversation
@chshersh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @neongreen, @gromakovsky and @flyingleafe to be potential reviewers. |
|
We have CI to answer this question 😉 . |
Doesn't work on Windows. |
Beda. @chshersh can you use cabal conditionals to disable it on Windows? @gromakovsky so does it work on macOS or not? Travis tests on macOS, right? |
Yes, Travis does test MacOS, but builds failed. |
|
It was expected that won't work on windows. Okay, I'll add cabal options to enable this only on linux. |
@neongreen @gromakovsky @domenkozar Seems like we can get even faster linking with |
You'd use |
I'm not sure it works properly on |
MacOS build in CI: https://travis-ci.org/input-output-hk/cardano-sl/jobs/221020730
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be broken on MacOS which is bad I think.
Same error on my macbook, btw (I don't use nix). |
I'm not a macOS expert and I don't even have macOS :( |
@chshersh can you try without |
@neongreen What do you mean by saying _ try without "-pgmP clang"_? Just remove this code, commit and wait untill somebody with mac build this? |
Remove, commit and wait until CI builds this |
I'll do it by myself actually |
@domenkozar how can I install Also, blocked by NixOS/nixpkgs#24744. |
Niklas is going to fix NixOS/nixpkgs#24744, but while we're waiting it'd be nice to get just |
|
It's not for CI, it's for developers. |
Ah, excuse my ignorance. That does make sense. Ideally you could use stack to only build one executable instead of all of them, but that's waiting on next Cabal release. Since |
Yes, I can. Will to it today then. |
@neongreen I'll open PR with |
This PR uses
gold
linker forcardano-sl
(should speed up build time).Details in the answer to this question:
http://stackoverflow.com/questions/43243322/how-to-link-with-the-gnu-gold-linker-instead-of-ld-in-haskell/43243323#43243323