This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
[DEVOPS-936] Fix tests.stylishHaskell output when files are utf-8 #3189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When stylish-haskell is run under the C locale processing files with
unicode characters it crashes with the error:
commitBuffer: invalid argument (invalid character)
So force the locale to be a UTF-8 one.
Use plain old diff because git diff records file mode changes which produces warnings when the patch is applied.
disassembler
approved these changes
Jul 4, 2018
|
I'm assuming stylish is failing on purpose because of the changes made. Looks good to me, lets pull that breakage out and merge! |
rvl
force-pushed
the
devops-936-fix-stylish-script
branch
from
e5d2efe
to
8ac1594
Compare
|
OK, yes I removed the commit which was intentionally breaking stylish-haskell. ⛄ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
stylish-haskell needs to be run under a utf-8 locale. Otherwise it will crash leaving a partially written file.
Linked issue
https://iohk.myjetbrains.com/youtrack/issue/DEVOPS-936
Type of change
QA Steps