Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[CDEC-437] Move Arbitrary instances from wallet to wallet-test #3259

Merged
merged 3 commits into from
Jul 20, 2018

Conversation

intricate
Copy link
Contributor

Description

As it stands, the Arbitrary instances for data types in wallet all exist in wallet when they should actually be exposed from a separate package, wallet-test.

Linked issue

https://iohk.myjetbrains.com/youtrack/issue/CDEC-437

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

Copy link
Contributor

@mhuesch mhuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@intricate intricate force-pushed the intricate/CDEC-437 branch 2 times, most recently from f8cd082 to c322da8 Compare July 19, 2018 16:40
@erikd erikd merged commit 5b72463 into develop Jul 20, 2018
@intricate intricate deleted the intricate/CDEC-437 branch July 20, 2018 13:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants