Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[CDEC-432] Free networking from the "blockchain packages" #3261

Merged
merged 1 commit into from
Jul 17, 2018

Conversation

mhuesch
Copy link
Contributor

@mhuesch mhuesch commented Jul 17, 2018

Description

Change the imports of JsonLog and Mockable from networking to core (where the modules are now prefixed by Pos.Core.). This allows networking to float up until it is right below infra.

Linked issue

https://iohk.myjetbrains.com/youtrack/issue/CDEC-432

Type of change

  • [~] 🐞 Bug fix (non-breaking change which fixes an issue)
  • [~] 🛠 New feature (non-breaking change which adds functionality)
  • [~] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • [~] 🔨 New or improved tests for existing code
  • [~] ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.

Testing checklist

  • [~] I have added tests to cover my changes.
  • All new and existing tests passed.
    ^ Module level refactoring (switching of imports between packages). Existing tests should be sufficient.

This commit changes the imports of `JsonLog` and `Mockable` from
`networking` to `core` (where the modules are now prefixed by
`Pos.Core.`). This allows `networking` to float up until it is
right below `infra`.
@mhuesch mhuesch self-assigned this Jul 17, 2018
@mhuesch mhuesch merged commit f6be112 into develop Jul 17, 2018
@mhuesch mhuesch deleted the mhuesch/CDEC-432-2 branch July 17, 2018 21:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants