This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
[CDEC-403] Remove partial field accessors from HandlerSpec, InductiveValidationError, InvariantViolation and ValidationResult data types.
#3263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
requested review from
adinapoli-iohk,
denisshevchenko and
parsonsmatt
as code owners
erikd
previously requested changes
Jul 18, 2018
| | UnknownHandler Word8 ByteString | ||
| -- | ConvHandler hsReplyType | ||
| = ConvHandler !MessageCode | ||
| | UnknownHandler !Word8 !ByteString | ||
| deriving (Show, Generic, Eq) | ||
|
|
||
| instance Bi HandlerSpec where |
There was a problem hiding this comment.
We don't seem to have golden/bitripping tests for HandlerSpec. At least not in the infra package.
We need that before we go changing things.
There was a problem hiding this comment.
Will do, I'll create a ticket.
There was a problem hiding this comment.
Tests created in #3268 and merged. Rebased [CDEC-403] onto develop with golden and bitripping tests still passing.
Jimbo4350
force-pushed
the
jordan/CDEC-403
branch
from
fd46ef6
to
0d5b014
Compare
mhuesch
approved these changes
Jul 19, 2018
| build InductiveInvalidBoot{..} = bprint | ||
| build (InductiveInvalidBoot | ||
| inductiveInvalidBoot | ||
| inductiveInvalidError) = bprint |
There was a problem hiding this comment.
👍 for removing uses of RecordWildcards. Maybe at some point we can go through and drop it from default-extensions / drop all uses.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove partial field accessors from
HandlerSpec,InductiveValidationError,InvariantViolationandValidationResultdata types.Linked issue
https://iohk.myjetbrains.com/youtrack/issue/CDEC-403
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)