-
Notifications
You must be signed in to change notification settings - Fork 631
[release/1.3.1] [DEVOPS-398] Testnet genesis data #3265
Conversation
Until |
I understood that the hotfix The DEVOPS-398 changes on this branch that I cherry-picked from develop did not all apply cleanly to |
Yes, my mistake. |
aa850e0
to
5a22e15
Compare
6245e4e
to
f4c86cc
Compare
Rebased on latest |
f4c86cc
to
e760af7
Compare
e760af7
to
fbc34aa
Compare
bbe770c
to
863563c
Compare
863563c
to
ff98839
Compare
df6c603
to
0c61eb8
Compare
7af6671
to
d57d8c2
Compare
On this branch I have tested:
This sync successfully and proves that the validation errors I was seeing before is because I hadn't merged the right branch into my test branch.
This fails with:
which means there is probably something wrong with the (If wondering how to debug this, |
I'll try running the wallet on mainnet and staging after hydra builds everything. Unless you already have CO-354 in your branch (as of a few minutes ago) good chance that last commit resolves the issues you're having. |
c8ceb81
to
fec434f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the last 2 commits on this (c69ba4e & fec434f), and they look reasonable to me. However I think @intricate should give the final say since he masterminded the new configuration setup.
- mainnet_base - in the genesis spec protocolMagic requiresNetworkMagic is omitted and therefore gets the default setting NMMustBeJust. - mainnet_full - genesis data remains the same. - testnet_launch - do not inherit protocolConstants from mainnet_base_spec. Copy across these parameters. In this genesis spec, requiresNetworkMagic is explicitly stated as NMMustBeJust, even though that would be the default value. - testnet_full - new genesis data will be generated from testnet_launch and updated after starting the blockchain. - devnet, other "leaf configurations" have requiresNetworkMagic: NMMustBeNothing which overrides the mainnet_base setting. This is so that the address format of the devnets matches mainnet_full. For testnet, the YAML "inheritance" direction is now: mainnet_base -> testnet_launch -> testnet_full This ensures that testnet_full gets all the genesis spec attributes -- requiresNetworkMagic in particular.
New genesis data created with requiresNetworkMagic: NMMustBeJust.
fec434f
to
2e0d112
Compare
Thanks. Now that #3585 is merged, I have rebased on release/1.3.1 and also generated new genesis data from exactly this configuration.yaml (not one which was slightly different but effectively the same). |
2e0d112
to
3c7e805
Compare
This is based on top off #3585, which should be merged first.
Description
configuration.yaml
and rearranges the way the testnet sections inherit their config.Linked issue
QA Steps
Screenshot