Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[DEVOPS-980] Fix log collection in integration test #3380

Merged
merged 1 commit into from
Aug 10, 2018

Conversation

disassembler
Copy link
Contributor

Description

Linked issue

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

@disassembler disassembler force-pushed the devops-980-wallet-integration-log-artifact branch 3 times, most recently from 5e37dae to a1c9c2f Compare August 10, 2018 14:41
@disassembler disassembler force-pushed the devops-980-wallet-integration-log-artifact branch from a1c9c2f to edec151 Compare August 10, 2018 15:11
@disassembler disassembler changed the title [DEVOPS-980] Disable set +e in integration tests for additional logic [DEVOPS-980] Fix log collection in integration test Aug 10, 2018
Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good fix.

@disassembler disassembler merged commit 633b494 into develop Aug 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants