Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[DEVOPS-992] Fix x509 generator SANs to work with IP addresses #3390

Merged
merged 1 commit into from
Aug 22, 2018

Conversation

disassembler
Copy link
Contributor

@disassembler disassembler commented Aug 14, 2018

Currently on 1.3.0, if an IP SAN is set, it treats it as a DNS name instead and still throws an invalid certificate error, which also can break daedalus on the demo cluster. This is fixed in develop and proposed to be targeted to 1.3.1 release to fix this issue. This would also be an issue for any exchanges running the x509 tool manually to generate a CA that specified SAN's other than localhost, for example if they had a LAN or public IP they wanted the wallet to use and be secured/trusted with SSL by any application/browser with the ca.crt loaded into the trust store.

(cherry picked from commit 834ade8)

Description

https://iohk.myjetbrains.com/youtrack/issue/DEVOPS-992

Linked issue

https://iohk.myjetbrains.com/youtrack/issue/DEVOPS-992

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

@disassembler disassembler requested a review from erikd as a code owner August 14, 2018 02:41
@disassembler disassembler requested review from KtorZ and a team and removed request for erikd August 14, 2018 02:42
Copy link
Contributor

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rvl rvl merged commit 2a0d779 into release/1.3.1 Aug 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants