This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
[CBR-227] Go over TODOs, remove stray, add tickets #3393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
approved these changes
Aug 14, 2018
matt-noonan
approved these changes
Aug 14, 2018
kderme
approved these changes
Aug 14, 2018
|
Thanks everyone :) |
KtorZ
pushed a commit
that referenced
this pull request
Nov 9, 2018
[CBR-227] Go over TODOs, remove stray, add tickets
KtorZ
pushed a commit
to input-output-hk/cardano-wallet-legacy
that referenced
this pull request
Nov 9, 2018
…hk/check-all-wallet-TODOs [CBR-227] Go over TODOs, remove stray, add tickets
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only changes comments (and a few variable names). I went over the TODOs still in the code, removed ones that were no longer relevant or had already been done, and created tickets for the important ones that still remain. TODOs about coding style or that sort of thing I just left.