Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[CBR-227] Remove legacy wallet layer #3395

Merged
merged 1 commit into from
Aug 14, 2018
Merged

Conversation

edsko
Copy link
Contributor

@edsko edsko commented Aug 14, 2018

This was never used, and will never be used. That is unfortunate, but at this
point won't change, and having the legacy layer makes it more awkward to modify
the layer since we have to make modifications to a layer that is never actually
used.

Description

Linked issue

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

This was never used, and will never be used. That is unfortunate, but at this
point won't change, and having the legacy layer makes it more awkward to modify
the layer since we have to make modifications to a layer that is never actually
used.
@edsko edsko requested a review from KtorZ August 14, 2018 12:42
Copy link
Contributor

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that there are no changes from WalletLayer/Types.hs -> WalletLayer.hs beside the bracket functions that have been moved, LGTM 👍

@edsko
Copy link
Contributor Author

edsko commented Aug 14, 2018

Nope, there aren't :) Thanks!

@edsko edsko merged commit 68862ed into develop Aug 14, 2018
@edsko edsko deleted the remove-legacy-wallet-layer branch August 14, 2018 13:39
KtorZ pushed a commit that referenced this pull request Nov 9, 2018
KtorZ pushed a commit to input-output-hk/cardano-wallet-legacy that referenced this pull request Nov 9, 2018
…hk/remove-legacy-wallet-layer

[CBR-227] Remove legacy wallet layer
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants