This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
[CDEC-500] Add golden tests for Address #3405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Bi` & `Json` modules had a number of datatypes which were shared and could be factored out. This commit pulls them out into the `ExampleHelpers` module.
mhuesch
force-pushed
the
mhuesch/CDEC-500-2
branch
from
a85c456 to
e5faa88
Compare
Since we are modifying this for CO-354, and it's quite important to preserve backwards compatibility of Addresses, I've added 5 golden tests to ensure the various configurations of Addresses will have proper test coverage. 4 example Address datatypes are added to the 1 existing datatype, and all 5 are used for golden tests in both the `Json` and `Bi` modules.
mhuesch
force-pushed
the
mhuesch/CDEC-500-2
branch
from
e5faa88 to
f251526
Compare
Jimbo4350
suggested changes
Aug 15, 2018
| @@ -0,0 +1 @@ | |||
| "2RhQhCGqYPDpFgTsnBTbnvPvCwpqAkjwLqQkWpkqXbLRmNxd4xNd262nGsr8JiynyKRUeMLSJ9Ntho9i76uvBTrVXdJJG5yiNLb8frmUe5qX7E" | |||
There was a problem hiding this comment.
Was this JSON encoded? Same question for the other golden address files.
There was a problem hiding this comment.
Yeah good question - that should've raised eyebrows for me but I was too focused on finishing the job to notice.
It seems, though, like that's just the JSON format of Address for us: toJSON calls toObjectKey which uses addressF to call build.
Let me know what you think, since you've worked in the Json parts of the codebase more.
There was a problem hiding this comment.
Yep this is the right encoding, just double checked in GHCi. Definitely looks different to the usual key/value map style encoding.
There was a problem hiding this comment.
Cool, thanks for confirming.
Jimbo4350
approved these changes
Aug 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[CDEC-500] Add golden tests for
AddressSince we are modifying this for CO-354, and it's quite important to
preserve backwards compatibility of Addresses, I've added 5 golden
tests to ensure the various configurations of Addresses will have
proper test coverage.
Linked issue
https://iohk.myjetbrains.com/youtrack/issue/CDEC-500
Type of change
Developer checklist
^ we're adding test coverage, which is not very noteworthy, and can be mentioned in a CHANGELOG entry for the parent YT ticket.
Testing checklist