Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[CDEC-505] Move txp types from core to chain #3412

Merged
merged 1 commit into from
Sep 6, 2018
Merged

Conversation

ruhatch
Copy link
Contributor

@ruhatch ruhatch commented Aug 15, 2018

Description

Txp types belong in chain!

Linked issue

CDEC-505

Type of change

  • [~] 🐞 Bug fix (non-breaking change which fixes an issue)
  • [~] 🛠 New feature (non-breaking change which adds functionality)
  • [~] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • [~] 🔨 New or improved tests for existing code
  • [~] ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • [~] CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • [~] I have added tests to cover my changes.
  • [~] All new and existing tests passed.

QA Steps

Screenshots (if available)

Copy link
Member

@erikd erikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just need to convince CI :)

@ruhatch ruhatch force-pushed the ruhatch/CDEC-505 branch 7 times, most recently from 729f249 to 088a005 Compare August 16, 2018 20:54
@angerman angerman force-pushed the ruhatch/CDEC-505 branch 2 times, most recently from 0f429b9 to d53f8c7 Compare August 17, 2018 03:45
@ruhatch ruhatch merged commit a78fcd7 into develop Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants