Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[CBR-227] Avoid overflow in updateUTxO #3443

Merged
merged 1 commit into from
Aug 20, 2018

Conversation

edsko
Copy link
Contributor

@edsko edsko commented Aug 20, 2018

This is unlikely to happen in reality, but the tests were hitting this edge
case.

Description

The tests were failing in #3439 but the failure was completely unrelated to that particular ticket.

Linked issue

https://iohk.myjetbrains.com/youtrack/issue/CBR-227

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

@edsko edsko requested a review from uroboros August 20, 2018 12:56
Copy link
Contributor

@uroboros uroboros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready to go

This is unlikely to happen in reality, but the tests were hitting this edge
case.
@edsko edsko force-pushed the bugfix/avoid-overflow-in-updateUTxO branch from 09c6ed8 to 1f41420 Compare August 20, 2018 14:11
@edsko edsko merged commit 1453a90 into develop Aug 20, 2018
@edsko edsko deleted the bugfix/avoid-overflow-in-updateUTxO branch August 20, 2018 15:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants