Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[CBR-207] introduce 'katip' #3477

Merged
merged 1 commit into from
Aug 25, 2018
Merged

Conversation

CodiePP
Copy link
Contributor

@CodiePP CodiePP commented Aug 24, 2018

Description

We want to switch libraries from ‘log-warper’ to ‘katip’ as the latter promises to easily support JSON logging which is needed for structured logging.

The external library ‘katip’ is registered as a dependency in ‘stack.yaml’ and the cabal file of module ‘util’, where the new logging’s implementation will reside. No current code must use the new library, except the new tests.

  • no changes to existing code
  • adding files to 'util' only

Linked issue

CBR-207
CBR-97 (user story)

Type of change

  • [~] 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • [~] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • [~] 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • [~] ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • [~] CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

@CodiePP CodiePP self-assigned this Aug 24, 2018
@CodiePP CodiePP removed the request for review from 365andreas August 24, 2018 15:59
@CodiePP CodiePP force-pushed the adiemand/CBR-207/introduce-katip-cold branch from 54adde3 to bf175e2 Compare August 24, 2018 16:19
@CodiePP CodiePP mentioned this pull request Aug 24, 2018
7 tasks
Signed-off-by: Alexander Diemand <codieplusplus@apax.net>
@CodiePP CodiePP force-pushed the adiemand/CBR-207/introduce-katip-cold branch from bf175e2 to cd6fec9 Compare August 24, 2018 20:53
@CodiePP
Copy link
Contributor Author

CodiePP commented Aug 25, 2018

tested this PR #3477 and PR #3476 rebased on develop again (reverted commit 06b4f09..) for block syncing. it worked up to epoch 16 where develop anyway fails.

@CodiePP CodiePP merged commit 112db60 into develop Aug 25, 2018
@CodiePP CodiePP deleted the adiemand/CBR-207/introduce-katip-cold branch October 26, 2018 08:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants