-
Notifications
You must be signed in to change notification settings - Fork 632
[CDEC-505] Move Pos.Core.Ssc to Pos.Chain.Ssc #3601
Conversation
947c004
to
529ac99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; module level movements and code block movements; no funny business.
import Pos.Chain.Txp (checkTxPayload) | ||
import Pos.Core.Slotting (SlotId (..)) | ||
import Pos.Core.Ssc (checkSscPayload) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 seems good that these are in the same place now.
tests = and <$> sequence | ||
[ H.checkSequential $$discoverGolden | ||
, H.checkParallel $$discoverRoundTrip | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 moved from core
exampleSscPayload :: SscPayload | ||
exampleSscPayload = SharesPayload exampleSharesMap (exampleVssCertificatesMap 10 4) | ||
where | ||
exampleSharesMap = HM.fromList $ [(exampleStakeholderId, exampleInnerSharesMap 3 1)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 from core
|
||
genVssCertificatesMap :: ProtocolMagic -> Gen VssCertificatesMap | ||
genVssCertificatesMap pm = | ||
mkVssCertificatesMap <$> Gen.list (Range.linear 0 5) (genVssCertificate pm) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 : ⬆️ from core
[CDEC-505] Move Pos.Core.Ssc to Pos.Chain.Ssc
…hk/ruhatch/CDEC-505 [CDEC-505] Move Pos.Core.Ssc to Pos.Chain.Ssc
Description
Move
Pos.Core.Ssc
module set tochain
packageLinked issue
CDEC-505
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)