Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[CBR-345] apply minSeverity as soon as possible #3613

Merged
merged 1 commit into from
Sep 18, 2018

Conversation

CodiePP
Copy link
Contributor

@CodiePP CodiePP commented Sep 17, 2018

Signed-off-by: Alexander Diemand codieplusplus@apax.net

Description

apply minimum severity as soon as possible, and only forward messages to the logging framework that pass this filter

Linked issue

CBR-97 (user story)
CBR-345

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • [~] ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • [~] If my code deals with exceptions, it follows the guidelines.
  • [~] I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • [~] CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • [~] I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

tested in "block sync" test

@CodiePP CodiePP requested a review from erikd September 17, 2018 15:57
@CodiePP CodiePP force-pushed the adiemand/CBR-345/apply_minSeverity branch from d361521 to d249ee9 Compare September 17, 2018 16:14
Signed-off-by: Alexander Diemand <codieplusplus@apax.net>
@CodiePP CodiePP force-pushed the adiemand/CBR-345/apply_minSeverity branch from d249ee9 to e86c409 Compare September 17, 2018 20:56
@CodiePP CodiePP merged commit 3f04479 into develop Sep 18, 2018
@CodiePP CodiePP deleted the adiemand/CBR-345/apply_minSeverity branch September 18, 2018 06:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants