Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[CBR-345] Create symbolic link for log files. #3632

Merged
merged 3 commits into from
Sep 26, 2018

Conversation

365andreas
Copy link
Contributor

@365andreas 365andreas commented Sep 19, 2018

Description

Create a symbolic link for every log file created for UNIX-like systems. Symbolic link will follow the latest active log file.

For example:

  • logs/node -> node-20180919092116
  • logs/node-20180919091013
  • logs/node-20180919091536
  • logs/node-20180919092116

This allows a tail -F to follow the log files even when they are recreated under log rotation.

Also, create the log prefix directory on startup if it does not exist.

Linked issue

CBR-345

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

@365andreas 365andreas force-pushed the andreas/CBR-345/Create-symbolic-link-for-log-files branch 3 times, most recently from e3591b5 to 0f70c7a Compare September 20, 2018 16:48
@CodiePP CodiePP force-pushed the andreas/CBR-345/Create-symbolic-link-for-log-files branch from 0f70c7a to cb469f7 Compare September 24, 2018 07:30
@CodiePP
Copy link
Contributor

CodiePP commented Sep 24, 2018

rebased on develop

@CodiePP CodiePP requested a review from rvl September 24, 2018 08:14
Andreas Triantafyllos and others added 3 commits September 26, 2018 15:05
Signed-off-by: Alexander Diemand <codieplusplus@apax.net>
Signed-off-by: Alexander Diemand <codieplusplus@apax.net>
@365andreas 365andreas force-pushed the andreas/CBR-345/Create-symbolic-link-for-log-files branch from e5c6948 to cac16ab Compare September 26, 2018 12:06
@CodiePP CodiePP merged commit 30d9e98 into develop Sep 26, 2018
@365andreas 365andreas deleted the andreas/CBR-345/Create-symbolic-link-for-log-files branch September 28, 2018 12:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants