This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
[CBR-345] clean formatting of slots/epoch indexes #3633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikd
reviewed
Sep 20, 2018
| -- | temporary reimplementation of 'ords' from "Formatting" | ||
| -- because the original function converts the integer value to a real number | ||
| intords :: (Show n, Integral n) => F.Format r (n -> r) | ||
| intords = F.later go |
There was a problem hiding this comment.
Has this been submitted upstream? Even as a but report?
There was a problem hiding this comment.
yes, by Michael Bishop.
we have implemented this locally in 'core', but there were more instances of wrong formatting in other places. This is why it is moved to 'util'.
The problem is that grepping the logs for something like '4th epoch' will not hit the (wrongly formatted) entry '4.0th epoch'.
CodiePP
force-pushed
the
adiemand/CBR-345/clean_formatting_slots_and_epochs
branch
from
8226563 to
a16b395
Compare
|
rebased on |
CodiePP
force-pushed
the
adiemand/CBR-345/clean_formatting_slots_and_epochs
branch
from
a16b395 to
5fb5e4f
Compare
erikd
approved these changes
Sep 26, 2018
CodiePP
force-pushed
the
adiemand/CBR-345/clean_formatting_slots_and_epochs
branch
from
5fb5e4f to
0f08ccc
Compare
Signed-off-by: Alexander Diemand <codieplusplus@apax.net>
CodiePP
force-pushed
the
adiemand/CBR-345/clean_formatting_slots_and_epochs
branch
from
0f08ccc to
cb0bb90
Compare
CodiePP
deleted the
adiemand/CBR-345/clean_formatting_slots_and_epochs
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
clean formatting of slots/epoch indexes as proposed by @cleverca22
reason: there were more occurences of wrong formatting in the logs.
moved the formatting code 'intords' from
coretoutilreason: the formatting should be available in all modules
Linked issue
CBR-345
Type of change
Developer checklist
Testing checklist
QA Steps
verifiable in logs from benchmarking, or "block sync" test