Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[DEVOPS-1057] automated testing of yaml files #3649

Merged
merged 4 commits into from
Sep 27, 2018
Merged

Conversation

cleverca22
Copy link
Contributor

Description

this will automatically test that each yaml file to confirm it parses in haskell
currently, 2 non-parsing files are commented out pending comments from developers
and we need to find more yaml files and their matching types to add

Linked issue

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

@365andreas
Copy link
Contributor

365andreas commented Sep 21, 2018

This will fail because of:

- {{file}}.pub
- {{file}}

{{ and }} cause a:

testing: /nix/store/wvw52c9yb0009h8nd2cbh4g3mp0d9jda-template-demo.yaml yamlValidation: UnexpectedEvent {_received = Just (EventMappingStart Nothing), _expected = Nothing}

to be thrown.
Renaming {{file}} to tmpFileName will may do the job.

{{file}} is used in:

sed "s|{{file}}|$log_file|g" "$template" > "$conf_file"

@cleverca22 cleverca22 merged commit 4d849bf into develop Sep 27, 2018
@cleverca22 cleverca22 deleted the yamlValidation branch September 27, 2018 21:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants