Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[CBR-275] Change name of launcher log file. #3655

Merged
merged 1 commit into from
Sep 26, 2018

Conversation

365andreas
Copy link
Contributor

Description

Restore previous name of launcher log files.

Linked issue

[DDW-413]
[CBR-275]

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Launch Daedalus and launcher log file named "laucher" should be in the pub/ folder of logs.

Screenshots (if available)

, _lhBackend=FileTextBE
, _lhMinSeverity=Just Info
, _lhSecurityLevel=Just SecretLogLevel}
, _lhSecurityLevel=Just PublicLogLevel}
,LogHandler { _lhName="json", _lhFpath=Just "pub/node.pub"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Launcher does not need to log to this JSON file.

@365andreas 365andreas force-pushed the andreas/CBR-275/Rename-launcher-log-file branch from b4bea65 to ff89c4b Compare September 24, 2018 11:46
@365andreas 365andreas removed the wip label Sep 26, 2018
@365andreas 365andreas force-pushed the andreas/CBR-275/Rename-launcher-log-file branch from ff89c4b to ac1afd5 Compare September 26, 2018 11:51
@CodiePP CodiePP merged commit 9709f6f into develop Sep 26, 2018
@365andreas 365andreas deleted the andreas/CBR-275/Rename-launcher-log-file branch September 28, 2018 12:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants